Bug In sslclient.cpp?

[kackle123]

In sslclient.cpp (v2.5.3) should

Code: Select all

      BYTE content_type;

      rv = GetEncodedV3Record( ps, fds, rds, content_type, time_over );

      if ( err < 0 )

be:

Code: Select all

      BYTE content_type;

      rv = err = GetEncodedV3Record( ps, fds, rds, content_type, time_over );

      if ( err < 0 )

[kackle123]

I'll just assume I'm right.

[dciliske]

Sorry. Um, you are likely correct. That said... we (Netburner) aren't going to be really inspecting the version from 2.5.3, considering that there has been a massive overhaul of the libraries to add TLS support. Also, if you are using SSL, be aware that the Internet community at large has deprecated the use of SSL in favor of TLS. TLS is first available in release 2.7.1

-Dan

[kackle123]

...we (Netburner) aren't going to be really inspecting the version from 2.5.3, considering that there has been a massive overhaul of the libraries to add TLS support.

I only posted here in the very possible case that the bug still exists in the newer versions.

Also, if you are using SSL, be aware that the Internet community at large has deprecated the use of SSL in favor of TLS. TLS is first available in release 2.7.1

Thank you; I am aware of this. In fact, I received the cryptography libraries (separate from the NNDK) from NB months ago but haven't tested them in our prodcut yet. Can the separate cryptography libraries be used with my former version of NNDK or must I "blow away" my entire development environment and install 2.7.x on top of it?

[dciliske]

yea... Those will not work with 2.5.3. Well, you could try, but honestly I haven't even the foggiest idea whether it could be possible.

As for the concern in moving forward, I can say, that yes, this is as you suggested it be fixed.

-Dan